I'm trying to make form validation with ajax. Mine problem is elseif statement doesn't work properly
if (isset($_POST['submit'])){
//Create safe values for input into database
$username = mysqli_real_escape_string($mysqli, $_POST['username']);
$password = mysqli_real_escape_string($mysqli, $_POST['password']);
$company = mysqli_real_escape_string($mysqli, $_POST['company']);
$mail = mysqli_real_escape_string($mysqli, $_POST['mail']);
$adress = mysqli_real_escape_string($mysqli, $_POST['adress']);
$errorEmpty = false;
$errorTaken = false;
$errorMail = false;
//Check are required fields empty
if(empty($username) || empty($password) || empty($company) || empty($mail) || empty($adress)){
echo "<span class='form-error'>Fill in all fields!</span>";
$errorEmpty = true;
}
//Check is username already taken HERE IS THE PROBLEM!
elseif(isset($_POST['username'])){
$username = mysqli_real_escape_string($mysqli, $_POST['username']);
if(!empty($username)){
$username_query = mysqli_query($mysqli, "SELECT * FROM users WHERE user_username = '$username'");
$count=mysqli_num_rows($username_query);
if($count!=0)
{
echo"<span class='form-error'>Username is already taken! </span>";
$errorTaken = true;
}
}
}
//Check is mail adress correct
elseif(!filter_var($mail, FILTER_VALIDATE_EMAIL)) {
echo "<span class='form-error'> Write a valid e-mail adress!</span>";
$errorMail = true;
}
else{
//Create user
$add_user_sql = "INSERT INTO users (user_username, user_password, user_company, user_mail, user_adress)
VALUES ('".$username ."', '".$password."', '".$company."', '".$mail."', '".$adress."')";
$add_user_res = mysqli_query($mysqli, $add_user_sql)
or die(mysqli_error($mysqli));
//Close connection to MySQL
mysqli_close($mysqli);
echo "<span class='form-success'>Succesifuly registrated!</span>";
}
}
Problem is when i check is username already in database,because after that step every next elseif statement won't execute. When I put it on first place it stops execution of rest of code,same situation is when I put it on last place.Other conditions for checking empty fields and mail validation are working properly.
Either try to run your script from the command line, or add this line at the top of your script:
ini_set('display_errors', 1);
in this way you can see which error is stopping the execution.
Line that creates "problem" checks for your $_POST['username'].
elseif(isset($_POST['username'])){
If $_POST['username'] is set, the if-else statement won't go deeper (that's how it works). I would suggest something like this, to solve your problem:
// check if it was sent through your form
if (isset($_POST['submit']))
{
//Create safe values for input into database
$username = mysqli_real_escape_string($mysqli, $_POST['username']);
$password = mysqli_real_escape_string($mysqli, $_POST['password']);
$company = mysqli_real_escape_string($mysqli, $_POST['company']);
$mail = mysqli_real_escape_string($mysqli, $_POST['mail']);
$adress = mysqli_real_escape_string($mysqli, $_POST['adress']);
$errorEmpty = false;
$errorTaken = false;
$errorMail = false;
// check if any of the fields are empty
if(empty($username) || empty($password) || empty($company) || empty($mail) || empty($adress))
{
echo "<span class='form-error'>Fill in all fields!</span>";
$errorEmpty = true;
}
//if none of the fields are empty - check if username exists
$username_query = mysqli_query($mysqli, "SELECT * FROM users WHERE user_username = '$username'");
$count=mysqli_num_rows($username_query);
if($count!=0)
{
echo"<span class='form-error'>Username is already taken! </span>";
$errorTaken = true;
}
//Check is mail adress correct
if(!filter_var($mail, FILTER_VALIDATE_EMAIL))
{
echo "<span class='form-error'> Write a valid e-mail adress!</span>";
$errorMail = true;
}
// check if any of the errors are set to true
if(!$errorEmpty AND !$errorMail AND !$errorTaken)
{
//Create user
$add_user_sql = "INSERT INTO users (user_username, user_password, user_company, user_mail, user_adress)
VALUES ('".$username ."', '".$password."', '".$company."', '".$mail."', '".$adress."')";
$add_user_res = mysqli_query($mysqli, $add_user_sql) or die(mysqli_error($mysqli));
//Close connection to MySQL
mysqli_close($mysqli);
echo "<span class='form-success'>Succesifuly registrated!</span>";
}
}
Problem is fixed by writting this code,anyway thanks everyone for willing to help
if (isset($_POST['submit'])){
//Create safe values for input into database
$username = mysqli_real_escape_string($mysqli, $_POST['username']);
$password = mysqli_real_escape_string($mysqli, $_POST['password']);
$company = mysqli_real_escape_string($mysqli, $_POST['company']);
$mail = mysqli_real_escape_string($mysqli, $_POST['mail']);
$adress = mysqli_real_escape_string($mysqli, $_POST['adress']);
$errorEmpty = false;
$errorTaken = false;
$errorMail = false;
//Check are required fields empty
if(empty($username) || empty($password) || empty($company) || empty($mail) || empty($adress)){
echo "<span class='form-error'>Fill in all fields!</span>";
$errorEmpty = true;
}
//Check is mail adress correct
elseif(!filter_var($mail, FILTER_VALIDATE_EMAIL)) {
echo "<span class='form-error'> Write a valid e-mail adress!</span>";
$errorMail = true;
}
//Check is username already taken
if(isset($_POST['username'])){
$username = mysqli_real_escape_string($mysqli, $_POST['username']);
if(!empty($username)){
$username_query = mysqli_query($mysqli, "SELECT * FROM users WHERE user_username = '$username'");
$count=mysqli_num_rows($username_query);
if($count!=0)
{
echo"<span class='form-error'>Username is already taken! </span>";
$errorTaken = true;
}
}
}
if($errorEmpty == false && $errorMail == false && $errorTaken == false){
//Create user
$add_user_sql = "INSERT INTO users (user_username, user_password, user_company, user_mail, user_adress)
VALUES ('".$username ."', '".$password."', '".$company."', '".$mail."', '".$adress."')";
$add_user_res = mysqli_query($mysqli, $add_user_sql)
or die(mysqli_error($mysqli));
//Close connection to MySQL
mysqli_close($mysqli);
echo "<span class='form-success'>Succesifuly registrated!</span>";
}
}