too long

I am trying to pass the data from a form to an insertion script without having the form data cleared. I am using this function to act on the press of the submit button but I get nothing. It is even set to throw an error if the form is missing data but it doesn't even get that far. I can only assume I am not calling it properly.

$(function() {
    $(".submit").click(function() {
        var facility = $("#facility").val();
        var riskclient = $("#riskclient").val();
        var riskdate = $("#riskdate").val();
        var dataString = 'facitlity=' + facility + '&riskclient=' + riskclient + '&riskdate=' + riskdate;

        if (facility == '' || riskclient == '' || riskdate == '') {
            $('.success').fadeOut(200).hide();
            $('.error').fadeOut(200).show();
        } else {
            $.ajax({
                type: "POST",
                url: "insertriskass.php",
                data: dataString,
                success: function(){
                    $('.success').fadeIn(200).show();
                    $('.error').fadeOut(200).hide();
                }
            });
        }
        return false;
    });
});

<div class="body">   
    <div align='center'>
        <div class="tablebackground">
            <form  method ="post" name= "form"  id="form">            
                <table border='1' >
                    <tr>
                        <td>Facility</>
                        <td><input  type="text" name= "riskFacility" id="facility"></td>
                        <td rowspan='4'><input type="submit" name="submit" value="New Client" class="submit"/</td>
                    </tr>
                    <tr>
                        <td>Client</td>
                        <td><input required type="text" name="riskClientId" id="riskclient" value="<?php echo htmlspecialchars($_POST['riskClientId']); ?>"></td>
                    </tr>
                    <tr>
                        <td>Audit Date</td><td> <input required type="text" id="datepicker"     name="riskauddate" id="riskdate"></td>
                    </tr>
                </table>
            </form> 

It is definitely not passing anything to the insertion script. So again, I think I am calling it incorrectly.

I see your html tags are not closed properly

<div class="body">

  <form method="post" name="form" id="form">

    <table border='1'>
      <tr>
        <td>Facility</td>
        <td>
          <input type="text" name="riskFacility" id="facility">
        </td>
        <td rowspan='4'>
          <input type="submit" name="submit" value="New Client" class="submit" /> </td>
      </tr>
      <tr>
        <td>Client</td>
        <td>
          <input required type="text" name="riskClientId" id="riskclient" value="">
        </td>
      </tr>
      <tr>
        <td>Audit Date</td>
        <td>
          <input required type="text" id="datepicker" name="riskauddate" id="riskdate">
        </td>
      </tr>

    </table>
  </form>

and check if it comes to error call back

I think it's useful..

$(document).ready(function () {
$('#submit').on('click', function (event) {
    event.preventDefault();
    var facility = $("#facility").val();
var riskclient = $("#riskclient").val();
var riskdate = $("#riskdate").val();

var dataString = 'facitlity='+ facility + '&riskclient=' + riskclient + '&riskdate=' + riskdate; 
or 
// var datastring = $("#form").serialize();

if(facility=='' || riskclient=='' || riskdate=='' )
{
$('.success').fadeOut(200).hide();
$('.error').fadeOut(200).show();
}
else
{
$.ajax({
type: "POST",
url: "insertriskass.php",
data: dataString, 
success: function (msg) {
$('.success').fadeIn(200).show();
$('.error').fadeOut(200).hide();
}
});
}
return false;
});
})

event.preventDefault used to stop submit and page reload. datastring = $("#form").serialize(); used to submit all data values so no need to take each and every variable assign value.

You can refactor a little the code like this, revise your html tags. You have a double id property in an input, and missing clousure tags.

$(document).ready(function() {
    $(".submit").click(function(event) {
        event.PreventDefault();
        var facility = $("#facility").val();
        var riskclient = $("#riskclient").val();
        var riskdate = $("#riskdate").val();
        var dataString = 'facitlity=' + facility + '&riskclient=' + riskclient +    '&riskdate=' + riskdate;

        if (!facility || !riskclient || !riskdate) {
           $('.success').fadeOut(200).hide();
           $('.error').fadeOut(200).show();
        } else {
           //send ajax post
        }
    });
});