I'm trying to add new database user by these statements:
$insert = $db->prepare("CREATE USER ? IDENTIFIED BY ?");
$insert->bind_param('ss', $_POST['username'], $_POST['pass']);
$insert->execute();
Database gives me error: You have an error in your SQL syntax; (...) near '? IDENTIFIED BY ?' at line 1
When I try to add new user without ?
wildcards, everything is fine:
CREATE USER john IDENTIFIED BY 'johnpassword' //this works
,
but even using CONCAT("'", ?, "'")
for submitting data doesn't help.
I read in MySQL documentation that MySQL 5.7 should support prepared statements for CREATE USER
SQL statement, but with MySQLi it doesn't seem to.
I have omitted this problem by setting values in database's variables:
$insert = $db->prepare("SET @username = ? "); //store username in variable in database
$insert->bind_param('s', $_POST['username']);
$insert->execute();
$insert = $db->prepare("SET @password = ? "); //store password in variable in database
$insert->bind_param('s', $_POST['pass']);
$insert->execute();
$insert = $db->query("SET @query1 = CONCAT('CREATE USER ', @username,' IDENTIFIED BY \'', @password, '\'')");
if ($insert == false) {
print ($db->error);
}
$insert = $db->multi_query("PREPARE stmt FROM @query1"); //create user by using initialized variables. Note that you dont need to use prepared statements now
if ($insert == false) {
print ($db->error);
}
$insert = $db->query("EXECUTE stmt;");
if ($insert == false) {
print ($db->error);
}
$insert = $db->query("DEALLOCATE PREPARE stmt;");
if ($insert == false) {
print ($db->error);
}
$insert = $db->query("SET @password = null"); //clear plaintext password for safety reasons