Precursor: I'm just starting to get my feet wet with golang.
This may prove to a be a silly question as it's quite easy to perform these calculations but I'm going to ask it anyway as I didn't find an answer when Googling.
Is there a built in function that returns the minimum of a slice of int arguments:
func MinIntSlice(v []int) (m int) {
if len(v) > 0 {
m = v[0]
}
for i := 1; i < len(v); i++ {
if v[i] < m {
m = v[i]
}
}
return
}
OR the minimum of a variable number of int arguments:
func MinIntVarible(v1 int, vn ...int) (m int) {
m = v1
for i := 0; i < len(vn); i++ {
if vn[i] < m {
m = vn[i]
}
}
return
}
If not, is the best "convention" simply to create a package that contains helpers like this?
There is no built-in for this.
If you need this functionality only in one package you can write an un-exported function (e.g. minIntSlice).
If you need this functionality in multiple packages you can create a package and put similar functions there. You should consider making this package internal (https://golang.org/s/go14internal).
A few suggestions how to improve your code:
MinIntSlice will return 0 for an empty slice. However 0 is a valid min element as well. I think calling panic on an empty slice is a better option.
Use range loop:
for i, e := range v {
if i==0 || e < m {
m = e
}
}
by not giving the index of value it will give you the minimum value 0, which may not be present in given values, so you also have to apply condition on index.
As @kostya correctly stated there is no built-in min or max function in Golang.
However, I would suggest a slightly different solution:
func MinMax(array []int) (int, int) {
var max int = array[0]
var min int = array[0]
for _, value := range array {
if max < value {
max = value
}
if min > value {
min = value
}
}
return min, max
}
With that the problem of an empty slice is solved: a runtime error shows up (index out of range)
With sorting it can be shorter:
func MinIntSlice(v []int) int {
sort.Ints(v)
return v[0]
}
func MaxIntSlice(v []int) int {
sort.Ints(v)
return v[len(v)-1]
}
But don't forget to modify it for zero length slices on your taste.
Using @kostya's answer
Use range loop:
for i, e := range v {
if i==0 || e < m {
m = e
}
}
by not giving the index of value it will give you the minimum value 0, which may not be present in given values
if you don't care about input array
import . "sort"
func MinIntSlice(v []int){
Ints(v)
return z[0]
}
func MaxIntSlice(v []int){
Ints(v)
return z[len(v)-1]
}
// and MinMax version
func MinMax(v []int)(int,int){
Ints(v)
return z[0],z[len(v)-1]
}